Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8148d4ee0c09d4950de2b9fdd89c1a29922b84e5
      
https://github.com/WebKit/WebKit/commit/8148d4ee0c09d4950de2b9fdd89c1a29922b84e5
  Author: Sihui Liu <[email protected]>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp

  Log Message:
  -----------
  ASSERTION FAILED: record.body.isNull() in 
Storage::ReadOperation::finishReadRecord
https://bugs.webkit.org/show_bug.cgi?id=283240
rdar://140028885

Reviewed by Ben Nham.

It is possible that record body is actually not stored in blob storage, and 
ReadOperation::finishReadBlob will get a
null blob. In this case, we should not update Storage::ReadOperation::m_record, 
and should still try reading body from
record storage. Also this patch ensures an empty record is returned when we 
fail to read body after reading both blob
storage and record storage. This restores the old behavior before 286646@main.

* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::ReadOperation::finish):
(WebKit::NetworkCache::Storage::ReadOperation::finishReadRecord):
(WebKit::NetworkCache::Storage::ReadOperation::finishReadBlob):

Canonical link: https://commits.webkit.org/286732@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to