Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dc67c7bd3684b12516732e4a45a2298fb9429181
https://github.com/WebKit/WebKit/commit/dc67c7bd3684b12516732e4a45a2298fb9429181
Author: Richard Robinson <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.swift
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[Writing Tools] Can no longer type in compose view after using Writing Tools
proofreading in Mail
https://bugs.webkit.org/show_bug.cgi?id=283329
rdar://140133728
Reviewed by Abrar Rahman Protyasha.
This is essentially the same bug as https://commits.webkit.org/283274@main.
This time, even though there
was supposed to be logic to ensure that the view got removed when there were no
longer any active effects,
the logic was flawed due to the wrong order of operations; the call to remove
the view happened prior to
the effects actually being set to `nil`.
Fix by ensuring that the order of operations of when the effects are set to
`nil` and when the view is
requested to be removed is correct.
*
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.swift:
(setActivePonderingEffect(_:)):
(setActiveReplacementEffect(_:)):
Canonical link: https://commits.webkit.org/286776@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
