Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7fb07870ad51fa511629e16e59e70fed3d075bbe
https://github.com/WebKit/WebKit/commit/7fb07870ad51fa511629e16e59e70fed3d075bbe
Author: Brandon Stewart <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1.html
Log Message:
-----------
[css-masonry] Update Intrinsic Sizing Rows 004 Mix1 Expected / Ref Test Case
https://bugs.webkit.org/show_bug.cgi?id=283068
rdar://problem/139815982
Reviewed by Sammy Gill.
Use Ahem font and add colors to work around font sizing issues.
* Grid 1
Row 3 needs to span at least 2ch, because item 1 in the test case has a height
of 2ch.
Therefore, item "3 3" should set a similar height of 2ch.
* Grid 2
Row 1 needs a height of 3ch, because in the original test case "2 2" and "3 3"
will be placed in this row during track sizing.
Row 3 needs to span at least 2ch, because item 5 in the test case has a height
of 2ch.
Therefore, item "3 3" should set a similar height of 2ch.
Item 5 needs a height of 2ch, because it is set to that in the original test
case.
* Grid 6
Remove extra 5 not found in original test case.
* Grid 7
Set the grid-template-columns, because the second column will be incorrectly
computed without "30px auto".
Row 1 need a height of 3ch.
Row 4 needs to be a max-content, which is 3ch.
Simplify item 5 to just a span of 4.
* Grid 8
Set the grid-template-columns, because the second column will be incorrectly
computed without "30px auto".
Row 1 need a height of 3ch.
Row 4 needs to be a max-content, which is 3ch.
Simplify item 5 to just a span of 4 and height of 6ch.
* Grid 9
Set the grid-template-columns, because the second column will be incorrectly
computed without "30px auto".
Row 1 need a height of 3ch.
Row 4 needs to be a max-content, which is 3ch.
Simplify item 5 to just a span of 3 and height of 6ch.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1-ref.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-004-mix1.html:
Canonical link: https://commits.webkit.org/286779@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
