Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9de8ad6aad769be26a81306385b97d0b7a48bcb4
      
https://github.com/WebKit/WebKit/commit/9de8ad6aad769be26a81306385b97d0b7a48bcb4
  Author: Mike Wyrzykowski <[email protected]>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Texture.mm
    M Source/WebGPU/WebGPU/TextureView.mm

  Log Message:
  -----------
  [WebGPU] An invalid TextureView may be considered valid if its parent is 
destroyed
https://bugs.webkit.org/show_bug.cgi?id=283334
rdar://140161514

Reviewed by Cameron McCormack.

An invalid TextureView created from a valid Texture
should remain invalid throughout its lifetime and not
become valid if the parent Texture instance is destroyed.

We can simply remove the check for " || isDestroyed()" in
TextureView::isValid() because m_texture is set to a placeholder,
not nil, when the TextureView is destroyed.

Test: fuzz-275229.html continues to pass in debug.

* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::physicalTextureExtent):
Add debug assertion since it is never expected to reach this
function with a texture format of 'Undefined' or 'Force32'

* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::isValid const):

Canonical link: https://commits.webkit.org/286781@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to