Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4993aa174c49f7b5bfc0bc91069440cca262be16 https://github.com/WebKit/WebKit/commit/4993aa174c49f7b5bfc0bc91069440cca262be16 Author: Adrian Perez de Castro <ape...@igalia.com> Date: 2024-11-19 (Tue, 19 Nov 2024)
Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformerOpenSSL.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESCBCGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESCTRGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESGCMGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmEd25519GCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/GCryptUtilities.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp M Source/WebCore/platform/SharedBufferChunkReader.cpp M Source/WebCore/platform/audio/SincResampler.cpp M Source/WebCore/platform/audio/VectorMath.cpp M Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp M Source/WebCore/platform/graphics/PixelBufferConversion.cpp M Source/WebCore/platform/graphics/WOFFFileFormat.cpp M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp M Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h M Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp M Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp M Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h M Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.cpp M Source/WebCore/platform/graphics/skia/ColorSpaceSkia.h M Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp M Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp M Source/WebCore/platform/graphics/skia/GradientSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.h M Source/WebCore/platform/graphics/skia/PatternSkia.cpp M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp M Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.cpp M Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.h M Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp M Source/WebCore/platform/graphics/texmap/ClipStack.cpp M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedTileBuffer.cpp M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkBcmNexus.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkRialto.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp M Source/WebCore/platform/gtk/DragImageGtk.cpp M Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp M Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp M Source/WebCore/platform/image-decoders/bmp/BMPImageReader.h M Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp M Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp M Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp M Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp M Source/WebCore/platform/image-decoders/skia/ImageBackingStoreSkia.cpp M Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp M Source/WebCore/platform/libwpe/PlatformPasteboardLibWPE.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp M Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp M Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebCore/platform/soup/PublicSuffixStoreSoup.cpp M Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp M Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp M Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp Log Message: ----------- [GTK][WPE] Enable -Wunsafe-buffer-usage for the WebCore target https://bugs.webkit.org/show_bug.cgi?id=282597 Reviewed by Chris Dumez. Enable additional bounds safety checks from -Wunsafe-buffer-usage for the WebCore target for the GTK and WPE ports. There is a fair bit of WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} suppressions which need to be added, to be addressed later on. For the issues inside inline functions from Skia headers, use WTF_IGNORE_WARNINGS_IN_THIRD_PARTY_CODE_{BEGIN,END} around their inclusion. * Source/WebCore/CMakeLists.txt: * Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp: (WebCore::isPlayReadySanitizedInitializationData): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformerOpenSSL.cpp: (WebCore::crypt): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::initializePipeline): (WebCore::transceiverStatesFromWebRTCBin): (WebCore::GStreamerMediaEndpoint::pickAvailablePayloadType): (WebCore::GStreamerMediaEndpoint::transceiverBackendFromSender): (WebCore::GStreamerMediaEndpoint::collectTransceivers): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp: (WebCore::parseIceCandidateSDP): * Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp: (WebCore::copyBusData): * Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp: * Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESCBCGCrypt.cpp: (WebCore::gcryptEncrypt): (WebCore::gcryptDecrypt): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESCTRGCrypt.cpp: (WebCore::gcryptAESCTR): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESGCMGCrypt.cpp: (WebCore::gcryptDecrypt): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp: (WebCore::gcryptVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmEd25519GCrypt.cpp: (WebCore::verifyEd25519): * Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp: (WebCore::exponentVectorToUInt32): * Source/WebCore/crypto/gcrypt/GCryptUtilities.cpp: (WebCore::mpiZeroPrefixedData): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): * Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp: (WebCore::cpuPeriod): (WebCore::threadCPUUsage): * Source/WebCore/platform/SharedBufferChunkReader.cpp: * Source/WebCore/platform/audio/SincResampler.cpp: (WebCore::SincResampler::convolve): Deleted. * Source/WebCore/platform/audio/VectorMath.cpp: * Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp: (WebCore::MediaSessionGLib::ensureMprisSessionRegistered): * Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp: (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer): * Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp: (WebCore::GStreamerInternalAudioEncoder::initialize): * Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: (WebCore::copyGstreamerBuffersToAudioChannel): * Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp: (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): * Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: (WebCore::PlatformRawAudioData::copyTo): * Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: (webKitWebAudioSrcAllocateBuffer): * Source/WebCore/platform/graphics/PixelBufferConversion.cpp: * Source/WebCore/platform/graphics/WOFFFileFormat.cpp: (WebCore::readUInt32): (WebCore::readUInt16): (WebCore::convertWOFFToSfnt): * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::getEGLConfig): (WebCore::GLContext::createContextForEGLVersion): (WebCore::GLContext::isExtensionSupported): * Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp: (WebCore::FEColorMatrixSkiaApplier::apply const): * Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp: (WebCore::drmForeachDevice): (WebCore::DRMDeviceManager::initializeMainDevice): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::ensureGStreamerInitialized): (WebCore::registerWebKitGStreamerElements): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities): * Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp: (gstMemoryFastMallocNew): (gstAllocatorFastMallocMemCopy): (gstAllocatorFastMallocMemIsSpan): * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp: (webkit_text_combiner_pad_class_init): * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrame::createNV12): (WebCore::VideoFrame::createI420): (WebCore::VideoFrame::createI420A): (WebCore::VideoFrame::copyTo): * Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcGetProtocols): * Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: (WebCore::markupStartElement): (WebCore::markupEndElement): * Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: (WebCore::ProtectionSystemEvents::ProtectionSystemEvents): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp: (WebCore::GStreamerMediaDescription::extractCodecName const): * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp: * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h: * Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.cpp: * Source/WebCore/platform/graphics/skia/ColorSpaceSkia.h: * Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): * Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp: (WebCore::FloatRoundedRect::operator SkRRect const): * Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp: * Source/WebCore/platform/graphics/skia/GradientSkia.cpp: * Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp: * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h: * Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp: * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::applyElements const): * Source/WebCore/platform/graphics/skia/PathSkia.h: * Source/WebCore/platform/graphics/skia/PatternSkia.cpp: * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: * Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.cpp: (WebCore::SkiaHarfBuzzFont::glyphWidths): * Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.h: * Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: (WebCore::BitmapTexture::updateContents): * Source/WebCore/platform/graphics/texmap/ClipStack.cpp: (WebCore::ClipStack::addRoundedRect): * Source/WebCore/platform/graphics/texmap/TextureMapper.cpp: (WebCore::TextureMapper::beginPainting): (WebCore::TextureMapper::endPainting): (WebCore::computeGaussianKernel): (WebCore::TextureMapper::bindDefaultSurface): (WebCore::TextureMapper::updateProjectionMatrix): * Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp: (WebCore::transformedBoundingBox): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.cpp: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.cpp: (WebCore::CoordinatedPlatformLayerBufferVideo::createBufferFromDMABufMemory): (WebCore::CoordinatedPlatformLayerBufferVideo::createBufferFromGLMemory): (WebCore::CoordinatedPlatformLayerBufferVideo::paintToTextureMapper): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedTileBuffer.cpp: * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp: (WebCore::GStreamerCodecUtilities::parseHEVCProfile): * Source/WebCore/platform/gstreamer/GStreamerQuirkBcmNexus.cpp: (WebCore::GStreamerQuirkBcmNexus::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp: (WebCore::GStreamerQuirkBroadcom::configureElement): (WebCore::GStreamerQuirkBroadcom::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp: (WebCore::GStreamerQuirkRealtek::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkRialto.cpp: * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp: * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (webkit_video_encoder_class_init): * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h: (WebKitVideoEncoderBitRateAllocation::setBitRate): (WebKitVideoEncoderBitRateAllocation::getBitRate const): * Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp: (webkitFliteSrcCreate): * Source/WebCore/platform/gtk/DragImageGtk.cpp: * Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp: * Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processRLEData): * Source/WebCore/platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::getComponent const): (WebCore::BMPImageReader::getAlpha const): * Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::haveDecodedRow): * Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::parse): * Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::processDirectoryEntries): * Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::skipBytes): (WebCore::setPixel): (WebCore::JPEGImageDecoder::outputScanlines): * Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp: * Source/WebCore/platform/image-decoders/skia/ImageBackingStoreSkia.cpp: * Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::applyPostProcessing): * Source/WebCore/platform/libwpe/PlatformPasteboardLibWPE.cpp: (WebCore::PlatformPasteboard::getTypes const): (WebCore::PlatformPasteboard::write): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: * Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp: (WebCore::MockRealtimeAudioSourceGStreamer::reconfigure): * Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp: (WebCore::CertificateInfo::summary const): * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::SoupNetworkSession::clearOldSoupCache): * Source/WebCore/platform/soup/PublicSuffixStoreSoup.cpp: (WebCore::PublicSuffixStore::platformTopPrivatelyControlledDomain const): * Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp: (WebCore::TextCheckerEnchant::getGuessesForWord): * Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp: * Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp: (WebCore::MIMETypeRegistry::preferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::extensionsForMIMEType): Canonical link: https://commits.webkit.org/286804@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes