Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55c279735d5117f113f22590f07b9f075bef3f1b
      
https://github.com/WebKit/WebKit/commit/55c279735d5117f113f22590f07b9f075bef3f1b
  Author: Jessica Lee <jle...@apple.com>
  Date:   2024-11-19 (Tue, 19 Nov 2024)

  Changed paths:
    M LayoutTests/fast/urlpattern/urlpattern-component-expected.txt
    M LayoutTests/fast/urlpattern/urlpattern-component.html
    M Source/WebCore/Modules/url-pattern/URLPatternTokenizer.cpp
    M Source/WebCore/Modules/url-pattern/URLPatternTokenizer.h

  Log Message:
  -----------
  Add more descriptive error details to better diagnose URLPattern test failures
https://bugs.webkit.org/show_bug.cgi?id=283384
rdar://140233854

Reviewed by Sihui Liu.

It would be helpful to know why Tokenizer::processTokenizingError occurred and 
thus a reason / string should be forwarded. 
OpenSource/LayoutTests/fast/urlpattern/urlpattern-component.html also should 
better track which test case is being executed.

* LayoutTests/fast/urlpattern/urlpattern-component-expected.txt:
* LayoutTests/fast/urlpattern/urlpattern-component.html:
* Source/WebCore/Modules/url-pattern/URLPatternTokenizer.cpp:
(WebCore::URLPatternUtilities::Tokenizer::processTokenizingError):
(WebCore::URLPatternUtilities::Tokenizer::tokenize):
* Source/WebCore/Modules/url-pattern/URLPatternTokenizer.h:

Canonical link: https://commits.webkit.org/286836@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to