Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9cf5cec66cd0dfae4cf02b2bc64dde5d300422bc
https://github.com/WebKit/WebKit/commit/9cf5cec66cd0dfae4cf02b2bc64dde5d300422bc
Author: Keith Cirkel <[email protected]>
Date: 2024-11-20 (Wed, 20 Nov 2024)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/dom/PopoverData.cpp
M Source/WebCore/dom/PopoverData.h
A Source/WebCore/dom/ToggleEventTask.cpp
A Source/WebCore/dom/ToggleEventTask.h
M Source/WebCore/html/HTMLDetailsElement.cpp
M Source/WebCore/html/HTMLDetailsElement.h
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLElement.h
Log Message:
-----------
Deduplicate logic from queuePopoverToggleEventTask &
queueDetailsToggleEventTask
https://bugs.webkit.org/show_bug.cgi?id=268230
Reviewed by Darin Adler.
This deduplicates the logic of the two Toggle Events by creating a
separate ToggleEventTask which houses the two ToggleEvent states.
This means that Popover & Details elements only need to store a
reference to ToggleEventTask, and the `queue` function will execute
the necessary logic, and retain values from the initial queue.
This enables further use of ToggleEvents by other elements, such as
the HTMLDialogElement.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/PopoverData.cpp: Added.
(WebCore::PopoverData::ensureToggleEventTask):
* Source/WebCore/dom/PopoverData.h:
(WebCore::PopoverData::queuedToggleEventData const): Deleted.
(WebCore::PopoverData::setQueuedToggleEventData): Deleted.
(WebCore::PopoverData::clearQueuedToggleEventData): Deleted.
* Source/WebCore/dom/ToggleEventTask.cpp: Added.
(WebCore::ToggleEventTask::create):
(WebCore::ToggleEventTask::queue):
* Source/WebCore/dom/ToggleEventTask.h: Added.
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::queueDetailsToggleEventTask):
(WebCore::HTMLDetailsElement::attributeChanged):
* Source/WebCore/html/HTMLDetailsElement.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::queuePopoverToggleEventTask):
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::hidePopoverInternal):
* Source/WebCore/html/HTMLElement.h:
Canonical link: https://commits.webkit.org/286884@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
