Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd803ec74fa5a693cbe09d1383e8ac7f546e42c7
https://github.com/WebKit/WebKit/commit/dd803ec74fa5a693cbe09d1383e8ac7f546e42c7
Author: Alan Baradlay <[email protected]>
Date: 2024-11-21 (Thu, 21 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderElementInlines.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/style/StyleAdjuster.cpp
Log Message:
-----------
[Cleanup][content-visibility] Make shouldApply*Containment functions match
spec language
https://bugs.webkit.org/show_bug.cgi?id=283485#
Reviewed by Antti Koivisto.
While matching spec language in itself is desirable, this patch fixes the
backwards logic of
shouldApplySizeContainment calling into isSkippedContentRoot (<- which is about
whether we've got content-visibility on a renderer)
where the spec says 'content-visibility' only applies to elements that can have
size containment.
(i.e. instead of shouldApplySizeContainment consulting isSkippedContentRoot now
isSkippedContentRoot calls shouldApplySizeContainment to check whether
c-v is applicable at all).
* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderElementInlines.h:
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const):
(WebCore::RenderElement::canContainFixedPositionObjects const):
(WebCore::RenderElement::shouldApplyAnyContainment const):
(WebCore::RenderElement::shouldApplySizeOrInlineSizeContainment const):
(WebCore::RenderElement::shouldApplyLayoutContainment const):
(WebCore::RenderElement::shouldApplySizeContainment const):
(WebCore::RenderElement::shouldApplyInlineSizeContainment const):
(WebCore::RenderElement::shouldApplyStyleContainment const):
(WebCore::RenderElement::shouldApplyPaintContainment const):
(WebCore::isSkippedContentRoot):
(WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const): Deleted.
(WebCore::RenderElement::shouldApplySizeOrStyleContainment const): Deleted.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::doesSizeContainmentApplyByDisplayType): Deleted.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
Canonical link: https://commits.webkit.org/286911@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
