Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b364108c2896962f5f87a506e6c45b7af1e3a99d
https://github.com/WebKit/WebKit/commit/b364108c2896962f5f87a506e6c45b7af1e3a99d
Author: Nikolaos Mouchtaris <[email protected]>
Date: 2024-11-21 (Thu, 21 Nov 2024)
Changed paths:
M Source/WebCore/animation/AnimationTimelinesController.cpp
M Source/WebCore/animation/AnimationTimelinesController.h
Log Message:
-----------
REGRESSION(286771@main): ASSERTION FAILED: &object == m_impl->template
get<T>() in WTF::WeakPtr<WebCore::WebAnimation,
WebCore::WeakPtrImplWithEventTargetData>::WeakPtr(const T &,
EnableWeakPtrThreadingAssertions) under AnimationTimelinesController::setTi
https://bugs.webkit.org/show_bug.cgi?id=283346
rdar://140180425
Reviewed by Antoine Quint.
We need to keep around a strong reference to the WebAnimation awaiting
attachment to prevent
it from being destroyed.
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::updateAnimationsAndSendEvents):
(WebCore::AnimationTimelinesController::setTimelineForName):
* Source/WebCore/animation/AnimationTimelinesController.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::~WebAnimation):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::setIsPendingTimelineAttachment):
(WebCore::WebAnimation::isPendingTimelineAttachment):
Canonical link: https://commits.webkit.org/286920@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
