Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a5e33cd709d019ce84dcc38850291518a49c95d
https://github.com/WebKit/WebKit/commit/4a5e33cd709d019ce84dcc38850291518a49c95d
Author: Elliott Williams <[email protected]>
Date: 2024-11-21 (Thu, 21 Nov 2024)
Changed paths:
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Log Message:
-----------
[Public Xcode build] webrtc's access to symlinked SDK headers lost after
upstream sync
https://bugs.webkit.org/show_bug.cgi?id=283505
rdar://140357783
Reviewed by Alexey Proskuryakov.
https://commits.webkit.org/280416@main removed the
$(WK_DERIVED_SDK_HEADERS_DIR) dependency that libwebrtc was using to
always run after WTF's symlink headers phase:
@@ -23884,7 +23829,7 @@
"$(PROJECT_DIR)/Configurations/libwebrtc.exp",
"$(PROJECT_DIR)/Configurations/libwebrtc.testing.exp",
"$(PROJECT_DIR)/Configurations/libwebrtc.debug.exp",
- "$(WK_DERIVED_SDK_HEADERS_DIR)",
+
"$(PROJECT_DIR)/Configurations/libwebrtc.release.exp",
);
name = "Generate Export Files";
outputFileListPaths = (
This is the second time an upstream sync has accidentally deleted this
line. Instead of putting it back, create a separate script phase that
holds the dependency, same as we do for ANGLE's targets. Hopefully that
makes it less likely to conflict during a sync, and easier to see when
it does.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/286921@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
