Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 11d3279e047968cb88bbe02d15fc95675aec64fe
https://github.com/WebKit/WebKit/commit/11d3279e047968cb88bbe02d15fc95675aec64fe
Author: Youenn Fablet <[email protected]>
Date: 2024-11-22 (Fri, 22 Nov 2024)
Changed paths:
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
Log Message:
-----------
LibWebRTCAudioModule does not need to nullify its log timer
rdar://140405398
https://bugs.webkit.org/show_bug.cgi?id=283547
Reviewed by Jean-Yves Avenard.
LibWebRTCAudioModule is now sure to be destroyed in main thread as it is noted
as DestructionThread::Main.
We can thus change its log timer to be a Timer instead of a unique_ptr<Timer>.
And we can remove the code that makes sure to destroy the Timer in main thread.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::LibWebRTCAudioModule):
(WebCore::LibWebRTCAudioModule::~LibWebRTCAudioModule):
(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::StopPlayout):
(WebCore::LibWebRTCAudioModule::pollAudioData):
(WebCore::LibWebRTCAudioModule::Terminate): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
(WebCore::LibWebRTCAudioModule::stop): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::~LibWebRTCProvider):
Canonical link: https://commits.webkit.org/286948@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes