Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a58bf5dbacc3f73b940962c0f2d881b9178dbbb
https://github.com/WebKit/WebKit/commit/4a58bf5dbacc3f73b940962c0f2d881b9178dbbb
Author: Jean-Yves Avenard <[email protected]>
Date: 2024-11-22 (Fri, 22 Nov 2024)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
Playback doesn't always resume after a seek
https://bugs.webkit.org/show_bug.cgi?id=283275
rdar://140097993
Reviewed by Youenn Fablet.
Exact comparison between MediaTime's double and MediaTime's rational can fail
due to precision loss.
As a workaround, we instead check that the difference between the two is less
than 1ms.
Manually tested: In our tests, WebKitTestRunner runs without a visible window,
and so the issue which is highly
timing dependent can't be consistently reproduced.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::seekInternal):
Canonical link: https://commits.webkit.org/286956@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
