Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fc4a7ef39c0ebd793c8a6e247989d3233af318f
      
https://github.com/WebKit/WebKit/commit/0fc4a7ef39c0ebd793c8a6e247989d3233af318f
  Author: Tyler Wilcock <[email protected]>
  Date:   2024-11-22 (Fri, 22 Nov 2024)

  Changed paths:
    M 
LayoutTests/accessibility/mac/attributed-string-for-text-marker-range-using-webarea-expected.txt
    M 
LayoutTests/accessibility/mac/attributed-string/attributed-string-for-range-with-options.html
    M 
LayoutTests/accessibility/mac/attributed-string/attributed-string-for-range.html
    M 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html
    M 
LayoutTests/accessibility/mac/content-editable-attributed-string-expected.txt
    M 
LayoutTests/platform/mac/accessibility/mac/selected-text-range-unconnected-object-expected.txt
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: Test output for attributed strings is missing many style attributes (text 
color, text shadow, sub/superscript, underline, and linethrough), meaning we 
have no test coverage for them
https://bugs.webkit.org/show_bug.cgi?id=283535
rdar://problem/140385001

Reviewed by Chris Fleizach.

With this commit, we now output foreground text color and background color, 
text shadow, sub/superscript, underline,
and linethrough styles for attributed strings. This will allow us to write 
tests ensuring their presence or lack thereof.

* 
LayoutTests/accessibility/mac/attributed-string-for-text-marker-range-using-webarea-expected.txt:
* 
LayoutTests/accessibility/mac/attributed-string/attributed-string-for-range-with-options.html:
* 
LayoutTests/accessibility/mac/attributed-string/attributed-string-for-range.html:
* 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html:
* LayoutTests/accessibility/mac/content-editable-attributed-string-expected.txt:
* 
LayoutTests/platform/mac/accessibility/mac/selected-text-range-unconnected-object-expected.txt:
Fix some tests that expected some hardcoded output, as there are now more 
attributes included in the output.

* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionForColor):
(appendColorDescription):
(createJSStringRef):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::descriptionForColor):
(WTR::appendColorDescription):
(WTR::createJSStringRef):

Canonical link: https://commits.webkit.org/286974@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to