Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82333e02424bb974217d946555656e995f354002
      
https://github.com/WebKit/WebKit/commit/82333e02424bb974217d946555656e995f354002
  Author: Simon Fraser <[email protected]>
  Date:   2024-11-23 (Sat, 23 Nov 2024)

  Changed paths:
    M Source/WTF/wtf/cocoa/SoftLinking.h
    M Source/WebCore/PAL/pal/cocoa/AccessibilitySoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/AppSSOSoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/QuartzCoreSoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm
    M Source/WebCore/PAL/pal/ios/SystemStatusSoftLink.mm
    M Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm
    M Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm

  Log Message:
  -----------
  Get FileSystem.h out of SoftLinking.h
https://bugs.webkit.org/show_bug.cgi?id=283524
rdar://140374614

Reviewed by Jer Noble.

SoftLinking.h including FileSystem.h pulls StringCommon.h into a lot of files:

662094 ms: 
/Volumes/Data/Development/system/webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/text/StringCommon.h
 (included 1189 times, avg 556 ms), included via:
  38x: SoftLinking.h SoftLinking.h FileSystem.h WTFString.h StringImpl.h

Fix that with a forward declare of NSErrorDomain, and an include in 
WebKitSwiftSoftLink.mm.

* Source/WTF/wtf/cocoa/SoftLinking.h:
* Source/WebCore/PAL/pal/cocoa/AccessibilitySoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/AppSSOSoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/QuartzCoreSoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm:
* Source/WebCore/PAL/pal/ios/SystemStatusSoftLink.mm:
* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:

Canonical link: https://commits.webkit.org/287011@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to