Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f5dcef9012aadb1d4517ae9164917051529469cd
https://github.com/WebKit/WebKit/commit/f5dcef9012aadb1d4517ae9164917051529469cd
Author: Antoine Quint <[email protected]>
Date: 2024-11-23 (Sat, 23 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-with-scroll-timeline-in-auto-subtree-expected.txt
M Source/WebCore/animation/WebAnimation.cpp
Log Message:
-----------
[scroll-animations] WPT test
css/css-contain/content-visibility/content-visibility-animation-with-scroll-timeline-in-auto-subtree.html
times out
https://bugs.webkit.org/show_bug.cgi?id=283498
rdar://140351602
Reviewed by Rob Buis.
The WPT test
`css/css-contain/content-visibility/content-visibility-animation-with-scroll-timeline-in-auto-subtree.html`
times out because the generated CSS Animations is waiting for its `ready`
promise to resolve before proceeding with the
rest of the test.
However, the `ready` promise will not resolve because the animation is
associated to an element within a tree with a
`content-visibility: auto` style. While the css-contain spec says in its
"Restrictions and Clarifications" section that
"while an element is skipped, CSS transitions and animations on the element do
not update", it does not specifically
spell out that its prevents the `ready` promise to be resolved.
So we update `WebAnimation::isSkippedContentAnimation()` to return `false` if
the animation is pending. This will not
prevent further updates from being canceled.
As a result
`css/css-contain/content-visibility/content-visibility-animation-with-scroll-timeline-in-auto-subtree.html`
works as expected, so we stop skipping it and update its expectation.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-with-scroll-timeline-in-auto-subtree-expected.txt:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::isSkippedContentAnimation const):
Canonical link: https://commits.webkit.org/287020@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
