Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a764e7f2334d721a22dd28f855a81f438d0dce17
      
https://github.com/WebKit/WebKit/commit/a764e7f2334d721a22dd28f855a81f438d0dce17
  Author: Simon Fraser <[email protected]>
  Date:   2024-11-25 (Mon, 25 Nov 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/DocumentFullscreen.cpp
    M Source/WebCore/dom/DocumentFullscreen.h
    M Source/WebCore/dom/DocumentInlines.h
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  Get Fullscreen.h out of DocumentInlines.h
https://bugs.webkit.org/show_bug.cgi?id=283650
rdar://problem/140544768

Reviewed by Timothy Hatcher.

Fullscreen.h pulls in HTMLMediaElement.h which pulls in a lot of media-related 
headers. It doesn't seem necessary
for fullscreen-related functions to be inline, so make them out-of-line so we 
can reduce what DocumentInlines.h pulls in.

Also un-inline functions in `DocumentFullscreen` (which is only used by 
WebKitLegacy).

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::isCapturing const):
(WebCore::Document::fullscreenManager):
(WebCore::Document::fullscreenManager const):
(WebCore::Document::checkedFullscreenManager):
(WebCore::Document::checkedFullscreenManager const):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::webkitFullscreenEnabled):
(WebCore::DocumentFullscreen::webkitFullscreenElement):
(WebCore::DocumentFullscreen::webkitIsFullScreen):
(WebCore::DocumentFullscreen::webkitFullScreenKeyboardInputAllowed):
(WebCore::DocumentFullscreen::webkitCurrentFullScreenElement):
(WebCore::DocumentFullscreen::webkitCancelFullScreen):
* Source/WebCore/dom/DocumentFullscreen.h:
(WebCore::DocumentFullscreen::webkitFullscreenEnabled): Deleted.
(WebCore::DocumentFullscreen::webkitFullscreenElement): Deleted.
(WebCore::DocumentFullscreen::webkitIsFullScreen): Deleted.
(WebCore::DocumentFullscreen::webkitFullScreenKeyboardInputAllowed): Deleted.
(WebCore::DocumentFullscreen::webkitCurrentFullScreenElement): Deleted.
(WebCore::DocumentFullscreen::webkitCancelFullScreen): Deleted.
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::hasMutationObserversOfType const):
(WebCore::Document::isCapturing const): Deleted.
(WebCore::Document::fullscreenManager): Deleted.
(WebCore::Document::fullscreenManager const): Deleted.
(WebCore::Document::checkedFullscreenManager): Deleted.
(WebCore::Document::checkedFullscreenManager const): Deleted.

Canonical link: https://commits.webkit.org/287070@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to