Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bbb1453996533ca5ee37942c88eeb0c51e8c49ba
https://github.com/WebKit/WebKit/commit/bbb1453996533ca5ee37942c88eeb0c51e8c49ba
Author: Simon Fraser <[email protected]>
Date: 2024-11-25 (Mon, 25 Nov 2024)
Changed paths:
M Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp
M Source/WebCore/dom/DocumentMarkerController.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/html/HTMLPlugInElement.cpp
M Source/WebCore/html/HTMLPlugInElement.h
M Source/WebCore/html/HTMLPlugInImageElement.cpp
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/loader/SubframeLoader.cpp
M Source/WebCore/page/Chrome.cpp
M Source/WebCore/page/ChromeClient.cpp
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/ios/EventHandlerIOS.mm
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.h
M Source/WebCore/rendering/RenderLayerCompositor.h
M Source/WebCore/rendering/RenderWidget.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
Log Message:
-----------
Clean up ChromeClient.h
https://bugs.webkit.org/show_bug.cgi?id=283656
rdar://problem/140544778
Reviewed by Matt Woodrow.
Remove some includes in ChromeClient.h by forward declaring more things,
including
`PluginUnavailabilityReason` which is pulled out of RenderEmbeddedObject.
For some compilers, we need to move the stub implementations to the cpp file.
* Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp:
* Source/WebCore/dom/DocumentMarkerController.cpp:
* Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::setReplacement):
* Source/WebCore/html/HTMLPlugInElement.h:
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::requestObject):
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createIconForFiles):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadPlugin):
* Source/WebCore/page/Chrome.cpp:
* Source/WebCore/page/ChromeClient.cpp:
(WebCore::ChromeClient::createWorkerClient):
(WebCore::ChromeClient::ensureScrollbarsController const):
(WebCore::ChromeClient::createScrollingCoordinator const):
(WebCore::ChromeClient::createBarcodeDetector const):
(WebCore::ChromeClient::getBarcodeDetectorSupportedFormats const):
(WebCore::ChromeClient::createFaceDetector const):
(WebCore::ChromeClient::createTextDetector const):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton const):
(WebCore::ChromeClient::unavailablePluginButtonClicked const):
(WebCore::ChromeClient::createWorkerClient): Deleted.
(WebCore::ChromeClient::createBarcodeDetector const): Deleted.
(WebCore::ChromeClient::getBarcodeDetectorSupportedFormats const): Deleted.
(WebCore::ChromeClient::createFaceDetector const): Deleted.
(WebCore::ChromeClient::createTextDetector const): Deleted.
(WebCore::ChromeClient::createScrollingCoordinator const): Deleted.
* Source/WebCore/page/EventHandler.cpp:
* Source/WebCore/page/ios/EventHandlerIOS.mm:
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
(WebCore::shouldUnavailablePluginMessageBeButton):
* Source/WebCore/rendering/RenderEmbeddedObject.h:
* Source/WebCore/rendering/RenderLayerCompositor.h:
* Source/WebCore/rendering/RenderWidget.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton const):
(WebKit::WebChromeClient::unavailablePluginButtonClicked const):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton const):
(WebChromeClient::unavailablePluginButtonClicked const):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Canonical link: https://commits.webkit.org/287075@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
