Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ce41f04b7758febc0912d7cbd117e82e0d4f34d
https://github.com/WebKit/WebKit/commit/1ce41f04b7758febc0912d7cbd117e82e0d4f34d
Author: Philippe Normand <[email protected]>
Date: 2024-11-26 (Tue, 26 Nov 2024)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp
Log Message:
-----------
[GStreamer] Tests using requestVideoFrameCallback on a paused element are a
constant failure
https://bugs.webkit.org/show_bug.cgi?id=283457
Reviewed by Xabier Rodriguez-Calvar.
There were two issues here:
- The preroll buffer is reported twice by appsink, once with the preroll signal
and once right after
the preroll signal. So this needs to be taken into account when filling rvfc
metadata.
- In case the negotiated framerate is variable buffer duration might not be
filled in buffers, so as
a workaround it is estimated from the first buffer PTS. It's not perfect but it
is better than
nothing.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamer::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamer::videoFrameMetadata):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:
(webkitGstBufferGetVideoFrameMetadata):
Canonical link: https://commits.webkit.org/287084@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
