Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b5524eb46be46e5cde16ebbd770bdcb0e4e54c6
      
https://github.com/WebKit/WebKit/commit/3b5524eb46be46e5cde16ebbd770bdcb0e4e54c6
  Author: Alan Baradlay <[email protected]>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    A 
LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside-expected.html
    A LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside.html
    M 
LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
    M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  [Ruby] Breakable ruby base content unexpectedly overflows its base container
https://bugs.webkit.org/show_bug.cgi?id=283694

Reviewed by Antti Koivisto.

RubyFormattingContext::applyRubyAlignOnBaseContent assumes base content is not 
breakable
and expects to see a base end boundary in the line run list.
This assumption leads to computing incorrect base content width (logical left 
of the run _after_ the base end) which results in incorrect alignment (i.e. 
base content is computed to be smaller
than what it really is which means extra distributable space).

* LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside-expected.html: 
Added.
* LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside.html: Added.
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::applyRubyAlignOnBaseContent):

(Kusa-Makura-background-canvas shows progression)

Canonical link: https://commits.webkit.org/287095@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to