Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 53f891ac8282b99b9f95b9ae5b6dc0de804713f8
https://github.com/WebKit/WebKit/commit/53f891ac8282b99b9f95b9ae5b6dc0de804713f8
Author: Antoine Quint <[email protected]>
Date: 2024-11-26 (Tue, 26 Nov 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/get-animations-inactive-timeline-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-with-transform-on-subject-expected.txt
M
LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios.html
M
LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac.html
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/ViewTimeline.h
Log Message:
-----------
[scroll-animations] progress-based timelines should update their current time
only during page rendering
https://bugs.webkit.org/show_bug.cgi?id=283715
rdar://140580999
Reviewed by Tim Nguyen.
Until now, querying the current time of a progress-based timeline would look at
the current
state of the source. However, the Web Animations specification clearly states
that timelines
update their current time during the "update animations and send events"
procedure (see
https://drafts.csswg.org/web-animations-1/#update-animations-and-send-events).
We update `ScrollTimeline` and `ViewTimeline` to compute a snapshot of the data
used to
compute the current time as the page is rendered.
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/get-animations-inactive-timeline-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-with-transform-on-subject-expected.txt:
*
LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios.html:
*
LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac.html:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::ScrollTimeline):
(WebCore::ScrollTimeline::cacheCurrentTime):
(WebCore::ScrollTimeline::documentWillUpdateAnimationsAndSendEvents):
(WebCore::ScrollTimeline::computeTimelineData const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::ViewTimeline):
(WebCore::ViewTimeline::cacheCurrentTime):
(WebCore::ViewTimeline::documentWillUpdateAnimationsAndSendEvents):
(WebCore::ViewTimeline::computeTimelineData const):
* Source/WebCore/animation/ViewTimeline.h:
Canonical link: https://commits.webkit.org/287100@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
