Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 48815528eb1ae739d681dda5460717c27db95304
https://github.com/WebKit/WebKit/commit/48815528eb1ae739d681dda5460717c27db95304
Author: Tim Nguyen <[email protected]>
Date: 2024-11-26 (Tue, 26 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListItem.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderTreeAsText.cpp
Log Message:
-----------
[::marker] Factor list item marker contents into a struct
https://bugs.webkit.org/show_bug.cgi?id=283730
rdar://140595246
Reviewed by Dan Glastonbury.
Factor them into a struct to make it easier to move out painting/content code
from RenderListMarker.
Also store the suffix + textWithoutSuffix, instead of generating substrings in
various places.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerTextWithoutSuffix const):
(WebCore::RenderListItem::markerTextWithSuffix const):
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::textRunForContent):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::relativeMarkerRect):
(WebCore::RenderListMarker::TextRunWithUnderlyingString::operator const
TextRun& const): Deleted.
(WebCore::RenderListMarker::textRun const): Deleted.
(WebCore::RenderListMarker::textWithoutSuffix const): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:
(WebCore::ListMarkerTextContent::isEmpty const):
(WebCore::ListMarkerTextContent::textWithSuffix const):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::markerTextForListItem):
Canonical link: https://commits.webkit.org/287107@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
