Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ad06a12f6537582bbade97c441afa958be760b4
      
https://github.com/WebKit/WebKit/commit/4ad06a12f6537582bbade97c441afa958be760b4
  Author: Tim Nguyen <[email protected]>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderListItem.cpp
    M Source/WebCore/rendering/RenderListMarker.cpp
    M Source/WebCore/rendering/RenderListMarker.h

  Log Message:
  -----------
  [::marker] Clean up margin computation
https://bugs.webkit.org/show_bug.cgi?id=283734
rdar://140599676

Reviewed by Alan Baradlay.

Rename `updateMargins` to `updateInlineMargins` since it only sets inline 
margins.

Split the logic between inside and outside markers, since one is used for 
marker as inline box, and the other one for marker as block box.

This will be useful to de-couple the margin logic from RenderListMarker.

No behavior change.

* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::computePreferredLogicalWidths):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::updateInlineMarginsAndContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateInlineMargins):
(WebCore::RenderListMarker::updateMarginsAndContent): Deleted.
(WebCore::RenderListMarker::updateMargins): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:

Canonical link: https://commits.webkit.org/287109@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to