Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04ad451617788ad31a4197cbe135a23ab8c76f2d
      
https://github.com/WebKit/WebKit/commit/04ad451617788ad31a4197cbe135a23ab8c76f2d
  Author: Abrar Rahman Protyasha <[email protected]>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  WebPage::PerformDictionaryLookupOfCurrentSelection is an unused IPC message
https://bugs.webkit.org/show_bug.cgi?id=283787
rdar://140648930

Reviewed by Tim Horton.

This patch removes this IPC message, since it has been unused since
157553@main. Moreover, the ctrl-cmd-D lookup shortcut now operates on
the text under the mouse location, rather than on the current selection,
system-wide, so it makes no sense to bring back the codepath that
exercised this IPC message.

* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/287152@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to