Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a710cc4e9b3fd23fee175c127d74d0f265ec60cc
https://github.com/WebKit/WebKit/commit/a710cc4e9b3fd23fee175c127d74d0f265ec60cc
Author: Alan Baradlay <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
R LayoutTests/fast/css/text-transform-select.html
A LayoutTests/fast/text/capitalize-decomposed-ligatures-expected.html
A LayoutTests/fast/text/capitalize-decomposed-ligatures.html
M
LayoutTests/imported/blink/fast/forms/select/select-text-transform-expected.html
R LayoutTests/platform/gtk/fast/css/text-transform-select-expected.txt
M LayoutTests/platform/ios/css1/text_properties/text_transform-expected.txt
R LayoutTests/platform/ios/fast/css/text-transform-select-expected.txt
R LayoutTests/platform/mac/fast/css/text-transform-select-expected.txt
M LayoutTests/platform/win/TestExpectations
R LayoutTests/platform/win/fast/css/text-transform-select-expected.txt
R LayoutTests/platform/wpe/fast/css/text-transform-select-expected.txt
M Source/WebCore/rendering/RenderText.cpp
Log Message:
-----------
[Text] Add support for titlecasing decomposed ligatures
https://bugs.webkit.org/show_bug.cgi?id=283754
<rdar://problem/140658460>
Reviewed by Antti Koivisto.
Replace u_totitle with u_strToTitle to support titlecasing decomposed ligatures.
When the candidate character has ligature (fi) while the titlecased version does
not (Fi),
u_totitle fails to make the conversion, while u_strToTitle simply tells us to
expand
the output buffer to be able to hold the enlarged content.
Using u_strToTitle also enables us to handle non-BPM content and support local
(FIXME).
(We can't just apply u_strToTitle on the entire content as, in addition to
titlecasing the first character, it also lowercases all others which is not
what 'text-transform: capitalize' expects. see
https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/ustring_8h.html#a47602e2c2012d77ee91908b9bbfdc063)
imported/blink/fast/forms/select/select-text-transform.html -> progression.
LayoutTests/fast/css/text-transform-select.html is exactly the same as
select-text-transform.html (see above) but with render tree dump -> remove.
* LayoutTests/fast/text/capitalize-decomposed-ligatures-expected.html: Added.
* LayoutTests/fast/text/capitalize-decomposed-ligatures.html: Added.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::capitalizeCharacter):
(WebCore::capitalize):
Canonical link: https://commits.webkit.org/287160@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
