Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1bf83c07887e3a653a605cf08600e1774247a3c9
https://github.com/WebKit/WebKit/commit/1bf83c07887e3a653a605cf08600e1774247a3c9
Author: Ahmad Saleem <[email protected]>
Date: 2024-11-29 (Fri, 29 Nov 2024)
Changed paths:
M LayoutTests/fast/css/default-bidi-css-rules-expected.txt
M LayoutTests/fast/css/default-bidi-css-rules.html
M LayoutTests/fast/text/international/bidi-LDB-2-HTML.html
M Source/WebCore/css/html.css
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
Log Message:
-----------
bdo element uses bidi-override instead of isolate-override
https://bugs.webkit.org/show_bug.cgi?id=283765
rdar://problem/140662417
Reviewed by Alan Baradlay.
This patch aligns WebKit with web specification [1]:
https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering
As per web specification, `bdo` should be `unicode-bidi: isolate-override`
instead of `bidi-override`. This also align us with Gecko / Firefox and
Blink / Chromium.
It is covered by existing imported WPT test case below:
> html/rendering/bidi-rendering/unicode-bidi-ua-rules.html
Since we haven't aligned with web specification fully, we progress only few more
sub-tests pass for `UA stylesheet rule for unicode-bidi, for <bdo>`.
In 259172@main , WebKit fixed bug to handle bidirectional override and
corresponding
glyph content width but it failed to account for `isolate-override`, this fixes
it as well.
* Source/WebCore/css/html.css:
(bdo, bdo[dir]):
(bdo): Deleted.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(TextUtil::width):
* LayoutTests/fast/css/default-bidi-css-rules-expected.txt:
* LayoutTests/fast/css/default-bidi-css-rules.html:
* LayoutTests/fast/text/international/bidi-LDB-2-HTML.html:
Canonical link: https://commits.webkit.org/287175@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
