Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e33ce5a6df0ea0984370cc578cdaefba33d4a856
      
https://github.com/WebKit/WebKit/commit/e33ce5a6df0ea0984370cc578cdaefba33d4a856
  Author: Alan Baradlay <[email protected]>
  Date:   2024-11-30 (Sat, 30 Nov 2024)

  Changed paths:
    A 
LayoutTests/fast/block/float/intruding-float-from-previous-blocks-expected.html
    A LayoutTests/fast/block/float/intruding-float-from-previous-blocks.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h

  Log Message:
  -----------
  Look previous block container siblings for overhanging floats
https://bugs.webkit.org/show_bug.cgi?id=283760

Reviewed by Antti Koivisto.

It's not sufficient to check only the previous sibling for intruding floats. 
Any previous
(non-formatting-context) sibling may have floats that overhang to current child.

* 
LayoutTests/fast/block/float/intruding-float-from-previous-blocks-expected.html:
 Added.
* LayoutTests/fast/block/float/intruding-float-from-previous-blocks.html: Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo): Move intruding float 
logic to collapseMargins and run it in a previous sibling based loop.
* Source/WebCore/rendering/RenderBlockFlow.h:

Canonical link: https://commits.webkit.org/287180@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to