Title: [111811] trunk/Source
- Revision
- 111811
- Author
- [email protected]
- Date
- 2012-03-22 19:26:12 -0700 (Thu, 22 Mar 2012)
Log Message
[BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
https://bugs.webkit.org/show_bug.cgi?id=81887
Patch by Jonathan Dong <[email protected]> on 2012-03-22
Reviewed by Rob Buis.
Source/WebCore:
Fixed SQL issue when clearing table logins and table never_remember.
No new tests.
* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):
Source/WebKit/blackberry:
Added two interface functions clearCredentials() and
clearNeverRememberSites() into class WebPage, which
should be used by UI to clear the stored credential
information and never remember sites.
Also implemented the corresponding functions in class
CredentialManager to call CredentialBackingStore
to perform the actual clear table work.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::clearCredentials):
(WebKit):
(BlackBerry::WebKit::WebPage::clearNeverRememberSites):
* Api/WebPage.h:
* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::clearCredentials):
(WebCore):
(WebCore::CredentialManager::clearNeverRememberSites):
* WebCoreSupport/CredentialManager.h:
(CredentialManager):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111810 => 111811)
--- trunk/Source/WebCore/ChangeLog 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebCore/ChangeLog 2012-03-23 02:26:12 UTC (rev 111811)
@@ -1,5 +1,20 @@
2012-03-22 Jonathan Dong <[email protected]>
+ [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
+ https://bugs.webkit.org/show_bug.cgi?id=81887
+
+ Reviewed by Rob Buis.
+
+ Fixed SQL issue when clearing table logins and table never_remember.
+
+ No new tests.
+
+ * platform/network/blackberry/CredentialBackingStore.cpp:
+ (WebCore::CredentialBackingStore::clearLogins):
+ (WebCore::CredentialBackingStore::clearNeverRemember):
+
+2012-03-22 Jonathan Dong <[email protected]>
+
[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135
Modified: trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp (111810 => 111811)
--- trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp 2012-03-23 02:26:12 UTC (rev 111811)
@@ -404,7 +404,7 @@
ASSERT(m_database.isOpen());
ASSERT(m_database.tableExists("logins"));
- HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE * FROM logins"),
+ HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM logins"),
false, "Failed to clear table logins");
return true;
@@ -415,7 +415,7 @@
ASSERT(m_database.isOpen());
ASSERT(m_database.tableExists("never_remember"));
- HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE * FROM never_remember"),
+ HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"),
false, "Failed to clear table never_remember");
return true;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (111810 => 111811)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-23 02:26:12 UTC (rev 111811)
@@ -4874,6 +4874,20 @@
clearDatabase(d->m_page->groupName());
}
+void WebPage::clearCredentials()
+{
+#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
+ credentialManager().clearCredentials();
+#endif
+}
+
+void WebPage::clearNeverRememberSites()
+{
+#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
+ credentialManager().clearNeverRememberSites();
+#endif
+}
+
void WebPage::clearCache()
{
clearMemoryCaches();
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (111810 => 111811)
--- trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-03-23 02:26:12 UTC (rev 111811)
@@ -191,6 +191,8 @@
void clearCookies();
void clearCache();
void clearLocalStorage();
+ void clearCredentials();
+ void clearNeverRememberSites();
void runLayoutTests();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (111810 => 111811)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-03-23 02:26:12 UTC (rev 111811)
@@ -1,5 +1,32 @@
2012-03-22 Jonathan Dong <[email protected]>
+ [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
+ https://bugs.webkit.org/show_bug.cgi?id=81887
+
+ Reviewed by Rob Buis.
+
+ Added two interface functions clearCredentials() and
+ clearNeverRememberSites() into class WebPage, which
+ should be used by UI to clear the stored credential
+ information and never remember sites.
+ Also implemented the corresponding functions in class
+ CredentialManager to call CredentialBackingStore
+ to perform the actual clear table work.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::clearCredentials):
+ (WebKit):
+ (BlackBerry::WebKit::WebPage::clearNeverRememberSites):
+ * Api/WebPage.h:
+ * WebCoreSupport/CredentialManager.cpp:
+ (WebCore::CredentialManager::clearCredentials):
+ (WebCore):
+ (WebCore::CredentialManager::clearNeverRememberSites):
+ * WebCoreSupport/CredentialManager.h:
+ (CredentialManager):
+
+2012-03-22 Jonathan Dong <[email protected]>
+
[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.cpp (111810 => 111811)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.cpp 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.cpp 2012-03-23 02:26:12 UTC (rev 111811)
@@ -92,6 +92,16 @@
}
}
+void CredentialManager::clearCredentials()
+{
+ CredentialBackingStore::instance()->clearLogins();
+}
+
+void CredentialManager::clearNeverRememberSites()
+{
+ CredentialBackingStore::instance()->clearNeverRemember();
+}
+
} // namespace WebCore
#endif // ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.h (111810 => 111811)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.h 2012-03-23 02:24:00 UTC (rev 111810)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialManager.h 2012-03-23 02:26:12 UTC (rev 111811)
@@ -42,6 +42,8 @@
void autofillAuthenticationChallenge(const ProtectionSpace&, BlackBerry::WebKit::WebString& username, BlackBerry::WebKit::WebString& password);
void autofillPasswordForms(PassRefPtr<HTMLCollection> docForms);
void saveCredentialIfConfirmed(PageClientBlackBerry*, const CredentialTransformData&);
+ void clearCredentials();
+ void clearNeverRememberSites();
private:
friend CredentialManager& credentialManager();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
