Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2708384442e4830396f65f648320289852bc4503
https://github.com/WebKit/WebKit/commit/2708384442e4830396f65f648320289852bc4503
Author: Alan Baradlay <[email protected]>
Date: 2024-12-09 (Mon, 09 Dec 2024)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
Detect a change in border that affects a positioned object's height or
position
https://bugs.webkit.org/show_bug.cgi?id=284123#
Reviewed by Antti Koivisto.
Child is in the same (block) formatting context as its containing block so
intuitively _logical_ height is the right pick here, but
in WebKit logical height (confusingly) returns the height from the box's own
content point of view meaning that if the box
has 'writing-mode: vertical-*', its logical height is its width.
(In short, it does not matter if the child is orthogonal while sizing and
positing the child itself and we still use height as height
and width as width, flipping (height -> width, width -> height) should only
happen when laying out its content).
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-containing-block-height-changes.html:
Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
Canonical link: https://commits.webkit.org/287543@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
