Title: [111849] trunk/Source/WebCore
Revision
111849
Author
[email protected]
Date
2012-03-23 05:07:06 -0700 (Fri, 23 Mar 2012)

Log Message

Fixed minor WebInspector display issue
Clicking on disabled sections in Styles Sidebar Pane creates new elements.
https://bugs.webkit.org/show_bug.cgi?id=81925

Patch by Vlad Voicu <[email protected]> on 2012-03-23
Reviewed by Timothy Hatcher

No new tests should be required.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111848 => 111849)


--- trunk/Source/WebCore/ChangeLog	2012-03-23 12:02:11 UTC (rev 111848)
+++ trunk/Source/WebCore/ChangeLog	2012-03-23 12:07:06 UTC (rev 111849)
@@ -1,3 +1,17 @@
+2012-03-23  Vlad Voicu  <[email protected]>
+
+        Fixed minor WebInspector display issue
+        Clicking on disabled sections in Styles Sidebar Pane creates new elements.
+        https://bugs.webkit.org/show_bug.cgi?id=81925
+
+        Reviewed by Timothy Hatcher
+
+        No new tests should be required.
+
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
+        (WebInspector.StylePropertyTreeElement.prototype):
+
 2012-03-23  Kentaro Hara  <[email protected]>
 
         Unreviewed, rebaselined run-bindings-tests results.

Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (111848 => 111849)


--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-03-23 12:02:11 UTC (rev 111848)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-03-23 12:07:06 UTC (rev 111849)
@@ -1240,6 +1240,9 @@
 
     _handleEmptySpaceClick: function(event)
     {
+        if (!this.editable)
+            return;
+
         if (this._checkWillCancelEditing())
             return;
 
@@ -2025,6 +2028,9 @@
         event.consume();
 
         if (event.target === this.listItemElement) {
+            if (!this.section.editable) 
+                return;
+
             if (this.section._checkWillCancelEditing())
                 return;
             this.section.addNewBlankProperty(this.property.index + 1).startEditing();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to