Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ea2a8afbd89e36c72f4c7785538e206f4778730a
https://github.com/WebKit/WebKit/commit/ea2a8afbd89e36c72f4c7785538e206f4778730a
Author: Ahmad Saleem <[email protected]>
Date: 2024-12-14 (Sat, 14 Dec 2024)
Changed paths:
M LayoutTests/fast/css/all-keyword-direction-expected.html
M LayoutTests/fast/css/all-keyword-direction.html
M LayoutTests/fast/css/default-bidi-css-rules-expected.txt
M LayoutTests/fast/css/default-bidi-css-rules.html
M
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
M LayoutTests/fast/css/unicode-bidi-computed-value-expected.txt
M LayoutTests/fast/css/unicode-bidi-computed-value.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/unicode-bidi-parsing-001.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-expected.txt
M LayoutTests/inspector/css/shadow-scoped-style-expected.txt
M LayoutTests/platform/gtk/fast/forms/form-in-malformed-markup-expected.txt
M LayoutTests/platform/ios/fast/forms/form-in-malformed-markup-expected.txt
M LayoutTests/platform/mac/fast/forms/form-in-malformed-markup-expected.txt
M Source/WebCore/css/html.css
M Source/WebCore/editing/EditingStyle.cpp
M Source/WebCore/editing/EditingStyle.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm
Log Message:
-----------
Partial sync `bidirectional text` UA stylesheet rules as per Web Specification
https://bugs.webkit.org/show_bug.cgi?id=284620
rdar://141426858
Reviewed by Tim Nguyen.
This patch is to align WebKit with Web-Specification [1]:
[1] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering
It syncs partially bidirectional text user agent stylesheet rules to ensure that
respective HTML elements have respect direction based as per standard.
The WPT test changes are synced as per:
Upstream commit:
https://github.com/web-platform-tests/wpt/commit/e45da1637c6ae670bdc45929905506fca4f6d0bd
* Source/WebCore/css/html.css:
(hr):
(address, blockquote, center, div, figure, figcaption, footer, form, header,
hr,):
(bdi, output): Deleted.
* Source/WebCore/editing/EditingStyle.cpp:
(EditingStyle::textDirectionForSelection): textDirection could be `embed` or
`isolate` so assert both
* Source/WebCore/editing/EditingStyle.h:
Test Updates (API & Layout):
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt:
Progression
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt:
Progression
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt:
Rebaselined
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-expected.txt:
Progression
* LayoutTests/fast/css/all-keyword-direction.html: Added `3px` tolerance for
Windows Platform
* LayoutTests/fast/css/all-keyword-direction-expected.html: Rebaselined
* LayoutTests/fast/css/default-bidi-css-rules.html: Updated test for new
behavior
* LayoutTests/fast/css/default-bidi-css-rules-expected.txt: Rebaselined
*
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
Rebaseline
* LayoutTests/fast/css/unicode-bidi-computed-value-expected.txt: Rebaselined
* LayoutTests/fast/css/unicode-bidi-computed-value.html: Fixed test based on
change done by Blink
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/unicode-bidi-parsing-001.html:
Synced from WPT
* LayoutTests/inspector/css/shadow-scoped-style-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/forms/form-in-malformed-markup-expected.txt:
Rebaselined
* LayoutTests/platform/mac/fast/forms/form-in-malformed-markup-expected.txt:
Rebaselined
* LayoutTests/platform/gtk/fast/forms/form-in-malformed-markup-expected.txt:
Rebaselined
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
(ModifyTextWritingDirection): Update Test
Canonical link: https://commits.webkit.org/287842@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
