Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 149b496a66561bb257da18c35d4223ccc190c4c5
https://github.com/WebKit/WebKit/commit/149b496a66561bb257da18c35d4223ccc190c4c5
Author: Alan Baradlay <[email protected]>
Date: 2024-12-16 (Mon, 16 Dec 2024)
Changed paths:
M Source/WebCore/rendering/RenderText.cpp
Log Message:
-----------
RenderText returns incorrect value for isHorizontalWritingMode() when nested
in a vertical block container
https://bugs.webkit.org/show_bug.cgi?id=284598
Reviewed by Antti Koivisto.
This is caused by caching computed style values on RenderObject while
RenderObject does
not have style (RenderElements do). RenderText consults its parent for computed
style.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange): We can either update the value here or
simply
delete the function from RenderText. Only TextDecorationPainter calls this on a
non-RenderElement renderer -we could simply consult the parent or check the
style.
Canonical link: https://commits.webkit.org/287877@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes