Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59ef26a67c5fa01d40dc95265f35a10426c3fb46
https://github.com/WebKit/WebKit/commit/59ef26a67c5fa01d40dc95265f35a10426c3fb46
Author: Ahmad Saleem <[email protected]>
Date: 2024-12-16 (Mon, 16 Dec 2024)
Changed paths:
M LayoutTests/fast/css/default-bidi-css-rules-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt
M LayoutTests/inspector/css/shadow-scoped-style-expected.txt
M Source/WebCore/css/html.css
M Source/WebCore/html/HTMLElement.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm
Log Message:
-----------
Clean-up `unicode-bidi` handling code in HTMLElement.cpp and sync remaining
`dir` rules from Web Specification
https://bugs.webkit.org/show_bug.cgi?id=284740
rdar://141535263
Reviewed by Ryosuke Niwa.
This patch aligns WebKit with Web Specification [1]:
[1] https://html.spec.whatwg.org/#bidi-rendering
This patch merges below two Blink commits:
https://chromium-review.googlesource.com/c/chromium/src/+/5260610 &
https://chromium-review.googlesource.com/c/chromium/src/+/5262983
The patch clean-ups `bdi/output` handling code from
`collectPresentationalHintsForAttribute`
since now it is managed via `html.css` in UA stylesheet. Similarly, it also
adds remaining `dir` related rules in stylesheet to fix `bdo` behavior. This
give use opportunity to also remove redundant FIXME from our code.
* Source/WebCore/css/html.css:
(address, blockquote, center, div, figure, figcaption, footer, form, header,
hr,):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto):
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
Test Rebaselines:
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt:
Rebaselined
* LayoutTests/fast/css/default-bidi-css-rules-expected.txt: Rebaselined
* LayoutTests/inspector/css/shadow-scoped-style-expected.txt: Rebaselined
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
(TEST(WebKit, AttrStyle)): Updated
Canonical link: https://commits.webkit.org/287919@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
