Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58deabc6ad4703a9cc7bc54f7fdc0579f8f544cc
https://github.com/WebKit/WebKit/commit/58deabc6ad4703a9cc7bc54f7fdc0579f8f544cc
Author: Brianna Fan <[email protected]>
Date: 2024-12-18 (Wed, 18 Dec 2024)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py
Log Message:
-----------
`git-webkit pr` raises when on detached HEAD
https://bugs.webkit.org/show_bug.cgi?id=284312
rdar://141172754
Reviewed by Sam Sneddon.
Move logic for validating whether a PR can be made on a branch
to Git.is_suitable_branch_for_pull_request.
A branch is invalid if:
1. It is None
2. It is a default branch (e.g. main)
3. It is a prod branch
4. It is a remote branch and does not match the dev branch pattern
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.is_suitable_branch_for_pull_request):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pull_request_branch_point):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
Canonical link: https://commits.webkit.org/288027@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
