Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3cda95bf2634234a1120b0f9f68758a255c3738f
https://github.com/WebKit/WebKit/commit/3cda95bf2634234a1120b0f9f68758a255c3738f
Author: Alan Baradlay <[email protected]>
Date: 2024-12-25 (Wed, 25 Dec 2024)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderIFrame.cpp
M Source/WebCore/rendering/RenderIFrame.h
Log Message:
-----------
[Cleanup] Replace virtual bool RenderBox::shouldComputeSizeAsReplaced
function with is<RenderReplaced>
https://bugs.webkit.org/show_bug.cgi?id=285136
Reviewed by Antti Koivisto.
It turns out shouldComputeSizeAsReplaced() const { return
isReplacedOrAtomicInline() && !isNonReplacedAtomicInline(); }
simply means (block and inline level) replaced box.
...and RenderIFrame overrides this virtual function (and returns true) because
RenderIFrame also overrides isNonReplacedAtomicInline()
and returns true only when inline even though it is a RenderReplaced type.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatio const):
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::shouldComputeSizeAsReplaced const): Deleted.
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::shouldComputeSizeAsReplaced const): Deleted.
* Source/WebCore/rendering/RenderIFrame.h:
Canonical link: https://commits.webkit.org/288288@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
