Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e29574ecddbec7b4a803699bf40dbc5f362b1bbb
https://github.com/WebKit/WebKit/commit/e29574ecddbec7b4a803699bf40dbc5f362b1bbb
Author: Charlie Wolfe <[email protected]>
Date: 2025-01-01 (Wed, 01 Jan 2025)
Changed paths:
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
M Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.cpp
M Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
Log Message:
-----------
WebHistoryItemClient should send IPC to WebPageProxy instead of
WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=285240
rdar://142171346
Reviewed by Alex Christensen.
History items are scoped to the page, not the web process. Move the IPC message
that notifies the UI
process of history item changes from WebProcessProxy to WebPageProxy.
No change in behavior.
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didReceiveMessage):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::backForwardUpdateItem):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::hasProvisionalPageWithID const): Deleted.
(WebKit::WebProcessProxy::isAllowedToUpdateBackForwardItem const): Deleted.
These validation functions can be removed. The WebPageProxy receiving the IPC
should always have an
identifier that matches the pageID of the item.
(WebKit::WebProcessProxy::updateBackForwardItem): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.cpp:
(WebKit::WebHistoryItemClient::WebHistoryItemClient):
(WebKit::WebHistoryItemClient::historyItemChanged):
* Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
Canonical link: https://commits.webkit.org/288357@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
