Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4827b5fe002be3e7b195492caeba1092bb0a03b3
https://github.com/WebKit/WebKit/commit/4827b5fe002be3e7b195492caeba1092bb0a03b3
Author: Alex Christensen <[email protected]>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
Log Message:
-----------
WKDownloadDelegate.decideDestinationUsingResponse indicating a file that
already exists should cancel instead of crashing network process
https://bugs.webkit.org/show_bug.cgi?id=285316
rdar://142036600
Reviewed by Richard Robinson.
When I introduced WKDownload I introduced some restrictions on
decideDestinationUsingResponse
that were well intentioned but untested. Richard found that if you improperly
specify the destination,
we get an invalid IPC to a DownloadProxy object that no longer exists. The
didFail calls are
redundant. Calling the completionHandler with an empty destination will make
the download cancel.
* Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::DestinationFileAlreadyExists)):
Canonical link: https://commits.webkit.org/288401@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
