Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e20b11d5babece9b5ff0d9bf44341fd830853fb6
https://github.com/WebKit/WebKit/commit/e20b11d5babece9b5ff0d9bf44341fd830853fb6
Author: Sammy Gill <[email protected]>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
Remove dead code in RenderFlexibleBox::cacheFlexItemMainSize
https://bugs.webkit.org/show_bug.cgi?id=285360
rdar://142329298
Reviewed by Alan Baradlay.
cacheFlexItemMainSize is only reached via
maybeCacheFlexItemMainIntrinsicSize, which first calls
flexItemHasIntrinsicMainAxisSize(flexItem). That method will return
false if mainAxisIsFlexItemInlineAxis(flexItem) is true and cause us to
bail early without calling cacheFlexItemMainSize(flexItem). This means
that we cannot reach the code in cacheFlexItemMainSize that is dependent
on mainAxisIsFlexItemInlineAxis being true.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::cacheFlexItemMainSize):
Canonical link: https://commits.webkit.org/288432@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
