Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2367db901bdaf4744052802e810ded918c40d9d1
https://github.com/WebKit/WebKit/commit/2367db901bdaf4744052802e810ded918c40d9d1
Author: Ahmad Saleem <[email protected]>
Date: 2025-01-05 (Sun, 05 Jan 2025)
Changed paths:
M LayoutTests/fast/dom/constants-expected.txt
M LayoutTests/fast/dom/constants.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
M Source/WebCore/css/CSSPropertySourceData.h
M Source/WebCore/css/CSSRule.idl
R Source/WebCore/css/CSSUnknownRule.h
R Source/WebCore/css/CSSUnknownRule.idl
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/StyleRuleType.h
M Source/WebCore/css/StyleSheetContents.cpp
M Source/WebCore/inspector/InspectorStyleSheet.cpp
M Source/WebCore/style/RuleSetBuilder.cpp
M Source/WebKitLegacy/mac/DOM/DOMCSS.mm
M Source/WebKitLegacy/mac/DOM/DOMCSSRule.h
M Source/WebKitLegacy/mac/DOM/DOMCSSUnknownRule.mm
Log Message:
-----------
Remove non-standard `CSSUnknownRule`
https://bugs.webkit.org/show_bug.cgi?id=285397
rdar://142380626
Reviewed by Tim Nguyen.
This patch aligns WebKit with Web Specification [1]:
[1] https://drafts.csswg.org/cssom/#the-cssrule-interface
This patch removes this non-standard `CSSUnknownRule` and
this interface was already tagged 'LegacyNoInterfaceObject'
and from WebKit Legacy, it seems that it was marked deprecated
since macOS 10.4 (long time back).
Additionally, it was removed from Blink in 2015 below:
Commit:
https://source.chromium.org/chromium/chromium/src/+/6466a097d7552c489855841287430aa1d7e23c65
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSRule.idl:
* Source/WebCore/css/CSSUnknownRule.h: Removed.
* Source/WebCore/css/CSSUnknownRule.idl: Removed.
* Source/WebKitLegacy/mac/DOM/DOMCSSUnknownRule.mm:
* Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/css/CSSPropertySourceData.h:
(WebCore::CSSRuleSourceData::createUnknown): Deleted.
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleBase::visitDerived):
* Source/WebCore/css/StyleRuleType.h:
* Source/WebCore/css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::traverseSubresources const):
(WebCore::StyleSheetContents::mayDependOnBaseURL const):
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::flatteningStrategyForStyleRuleType):
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addChildRule):
* Source/WebKitLegacy/mac/DOM/DOMCSS.mm:
(kitClass):
* Source/WebKitLegacy/mac/DOM/DOMCSSRule.h:
> Test:
* LayoutTests/fast/dom/constants-expected.txt: Rebaselined
* LayoutTests/fast/dom/constants.html: Rebaselined
Canonical link: https://commits.webkit.org/288453@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
