Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70084d91dca4e6a7f11ee762f04a94c6262eb2c7
https://github.com/WebKit/WebKit/commit/70084d91dca4e6a7f11ee762f04a94c6262eb2c7
Author: Youenn Fablet <[email protected]>
Date: 2025-01-06 (Mon, 06 Jan 2025)
Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebKit/GPUProcess/media/RemoteMediaRecorderPrivateWriterManager.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaRecorderPrivateWriterManager.h
Log Message:
-----------
REGRESSION(288091@main?): [macOS Debug wk2] Crash in
WebCore::MediaRecorderPrivateWriterAVFObjC::writeFrame
rdar://141840655
https://bugs.webkit.org/show_bug.cgi?id=285039
Reviewed by Jean-Yves Avenard.
Before the patch, RemoteMediaRecorderPrivateWriterManager would store the audio
and video track infos.
But each audio/video track info is specific to each recorder and not to each
RemoteMediaRecorderPrivateWriterManager.
This would confuse the GPU process if the same web page was using two recorders
together (the same track infos would be used for both).
This patch is moving track info to the writers map instead.
We also make sure that a compromised WebProcess will not be able to create null
pointer dereference in GPU process.
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/GPUProcess/media/RemoteMediaRecorderPrivateWriterManager.cpp:
(WebKit::RemoteMediaRecorderPrivateWriterManager::create):
(WebKit::RemoteMediaRecorderPrivateWriterManager::addAudioTrack):
(WebKit::RemoteMediaRecorderPrivateWriterManager::addVideoTrack):
(WebKit::RemoteMediaRecorderPrivateWriterManager::allTracksAdded):
(WebKit::RemoteMediaRecorderPrivateWriterManager::writeFrames):
(WebKit::RemoteMediaRecorderPrivateWriterManager::close):
* Source/WebKit/GPUProcess/media/RemoteMediaRecorderPrivateWriterManager.h:
Canonical link: https://commits.webkit.org/288462@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
