Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c6bfe500c5dc35b74d322616cb4da3807aedad7a
https://github.com/WebKit/WebKit/commit/c6bfe500c5dc35b74d322616cb4da3807aedad7a
Author: Lily Spiniolas <lily_spinio...@apple.com>
Date: 2025-01-06 (Mon, 06 Jan 2025)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/Platform/mac/MenuUtilities.h
M Source/WebKit/Platform/mac/MenuUtilities.mm
M Source/WebKit/Shared/mac/PDFContextMenu.h
M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
Internal clients unable to set context menu images
https://bugs.webkit.org/show_bug.cgi?id=285317
rdar://139537720
Reviewed by Abrar Rahman Protyasha and Wenson Hsieh.
Allow internal WebKit clients to enable context menu images.
When enabled, the ContextMenuAction of menu items is used
to determine which image to use, if available.
PDFContextMenuItems now store a ContextMenuAction so that
the image can be determined in the same manner. Each item's
ContextMenuAction is determined from its ContextMenuItemTag.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/Platform/mac/MenuUtilities.h:
* Source/WebKit/Platform/mac/MenuUtilities.mm:
(WebKit::symbolNameForAction):
* Source/WebKit/Shared/mac/PDFContextMenu.h:
* Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::platformMenuItems const):
(WebKit::WebExtensionContext::singleMenuItemOrExtensionItemWithSubmenu const):
(WebKit::WebExtensionContext::addItemsToContextMenu):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::updateMenuItemImage):
(WebKit::WebContextMenuProxyMac::getContextMenuItem):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::contextMenuActionFromTag const):
(WebKit::UnifiedPDFPlugin::contextMenuItem const):
(WebKit::UnifiedPDFPlugin::separatorContextMenuItem const):
Canonical link: https://commits.webkit.org/288471@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
