Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ab577eae862105feb01e8e486a60173712908817
https://github.com/WebKit/WebKit/commit/ab577eae862105feb01e8e486a60173712908817
Author: Etienne Segonzac <[email protected]>
Date: 2025-01-07 (Tue, 07 Jan 2025)
Changed paths:
A LayoutTests/overlay-region/big-edge-overlay-expected.txt
A LayoutTests/overlay-region/big-edge-overlay-horizontal-expected.txt
A LayoutTests/overlay-region/big-edge-overlay-horizontal.html
A LayoutTests/overlay-region/big-edge-overlay.html
M LayoutTests/overlay-region/overlay-element-expected.txt
M LayoutTests/overlay-region/overlay-element-overflow-expected.txt
M LayoutTests/overlay-region/overlay-element-overflow.html
M LayoutTests/overlay-region/overlay-element.html
M Source/WebCore/rendering/EventRegion.cpp
M Source/WebCore/rendering/EventRegion.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Log Message:
-----------
Some OverlayRegions do more harm than good
https://bugs.webkit.org/show_bug.cgi?id=285509
<rdar://140295708>
Reviewed by Mike Wyrzykowski.
We now skip OverlayRegions that start at an edge, are full width or full
height and cover the majority of the ScrollView's viewport.
This supersedes the fix from 286390@main, so we can remove the extra
region from the EventRegion.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(addOverlayEventRegions):
(configureScrollViewWithOverlayRegionsIDs):
Add a new check before adding an OverlayRegion rect to the final
set.
* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegion::EventRegion):
(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteScrollOverlayRegion): Deleted.
* Source/WebCore/rendering/EventRegion.h:
(WebCore::EventRegion::scrollOverlayRegion const): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Revert 286390@main.
* LayoutTests/overlay-region/big-edge-overlay-expected.txt: Added
* LayoutTests/overlay-region/big-edge-overlay-horizontal-expected.txt: Added.
* LayoutTests/overlay-region/big-edge-overlay-horizontal.html: Added.
* LayoutTests/overlay-region/big-edge-overlay.html: Added.
Add new tests.
* LayoutTests/overlay-region/overlay-element-expected.txt:
* LayoutTests/overlay-region/overlay-element-overflow-expected.txt:
* LayoutTests/overlay-region/overlay-element-overflow.html:
* LayoutTests/overlay-region/overlay-element.html:
Update the Overlay test to cover the case where we don't skip.
Canonical link: https://commits.webkit.org/288534@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
