Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f5f34b0db59c4ac616b9e3ad5cfcb62815c97f3e
https://github.com/WebKit/WebKit/commit/f5f34b0db59c4ac616b9e3ad5cfcb62815c97f3e
Author: Daniel Liu <[email protected]>
Date: 2025-01-07 (Tue, 07 Jan 2025)
Changed paths:
M JSTests/wasm/ipint-tests/ipint-test-type-conversion.js
M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
M Source/JavaScriptCore/runtime/OptionsList.h
Log Message:
-----------
Fix missing popFloat64's in IPInt and re-enable IPInt
https://bugs.webkit.org/show_bug.cgi?id=285547
rdar://142496259
Reviewed by Yusuke Suzuki.
IPInt truncation opcodes previously did not pop the necessary value from the
stack
(due to a missing popFloat64 during https://commits.webkit.org/280730@main in
f64
truncation operations). This led to the issues mentioned in
https://bugs.webkit.org/show_bug.cgi?id=285535
Adding these instructions fixes the issues encountered.
* JSTests/wasm/ipint-tests/ipint-test-type-conversion.js:
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.export.string_appeared_here.param.i64.result.i32.local.0.i32.wrap_i64.func.export.string_appeared_here.param.f32.result.i32.local.0.i32.trunc_f32_s.func.export.string_appeared_here.param.f32.result.i32.local.0.i32.trunc_f32_u.func.export.string_appeared_here.param.f64.result.i32.local.0.i32.trunc_f64_s.func.export.string_appeared_here.param.f64.result.i32.local.0.i32.trunc_f64_u.func.export.string_appeared_here.param.i32.result.i64.local.0.i64.extend_i32_s.func.export.string_appeared_here.param.i32.result.i64.local.0.i64.extend_i32_u.func.export.string_appeared_here.param.f32.result.i64.local.0.i64.trunc_f32_s.func.export.string_appeared_here.param.f32.result.i64.local.0.i64.trunc_f32_u.func.export.string_appeared_here.param.f64.result.i64.local.0.i64.trunc_f64_s.func.export.string_appeared_here.param.f64.result.i64.local.0.i64.trunc_f64_u.func.export.string_appeared_here.param.i32.result.f32.lo
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Source/JavaScriptCore/runtime/OptionsList.h:
Canonical link: https://commits.webkit.org/288560@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
