Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85fd6a98f9ec6eb343231cb499c9de2dfab89f74
https://github.com/WebKit/WebKit/commit/85fd6a98f9ec6eb343231cb499c9de2dfab89f74
Author: Philippe Normand <[email protected]>
Date: 2025-01-10 (Fri, 10 Jan 2025)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoRTPPacketizer.cpp
Log Message:
-----------
[GStreamer][WebRTC] webrtc/video-h264.html consistently times out
https://bugs.webkit.org/show_bug.cgi?id=285398
Reviewed by Xabier Rodriguez-Calvar.
To make this test pass the two main changes needed were to have support for
high and
constrained-high avc codec strings in the packetizer and then let the
VideoEncoderPrivate select the
underlying encoder using the output caps. Without this change x264enc was
selected due to its high
rank but it doesn't support constrained-high, hence the caps negotiation error.
For this test now
openh264enc is selected instead.
Driving-by, the input format handling for h264 was reworked a bit, also
removing the inexistant Y420
format.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp:
(WebCore::h264CapsFromCodecString):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderSupportsCodec):
(videoEncoderSetCodec):
(webkit_video_encoder_class_init):
(videoEncoderFindForCodec): Deleted.
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoRTPPacketizer.cpp:
(WebCore::GStreamerVideoRTPPacketizer::create):
Canonical link: https://commits.webkit.org/288701@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
