Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1c49c2d197b012cf591a97289eec7bae8804a87
https://github.com/WebKit/WebKit/commit/b1c49c2d197b012cf591a97289eec7bae8804a87
Author: Tim Nguyen <[email protected]>
Date: 2025-01-10 (Fri, 10 Jan 2025)
Changed paths:
A LayoutTests/fast/forms/range/sideways-lr-dragging-expected.txt
A LayoutTests/fast/forms/range/sideways-lr-dragging.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/html/shadow/SliderThumbElement.cpp
M Source/WebCore/platform/graphics/controls/SliderTrackPart.cpp
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
Log Message:
-----------
Support `input[type="range"]` in sideways-lr writing mode
https://bugs.webkit.org/show_bug.cgi?id=285571
rdar://142518818
Reviewed by Aditya Keerthi.
Painting already works properly.
To fix dragging the slider, use `WritingMode::isLogicalLeftInlineStart()`
instead of checking `isLeftToRightDirection()` / `isBidiLTR()`.
* LayoutTests/fast/forms/range/sideways-lr-dragging-expected.txt: Added.
* LayoutTests/fast/forms/range/sideways-lr-dragging.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
* Source/WebCore/platform/graphics/controls/SliderTrackPart.cpp:
(WebCore::SliderTrackPart::drawTicks const):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSliderTicks):
Canonical link: https://commits.webkit.org/288752@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
