Title: [111977] trunk/Source/WebCore
Revision
111977
Author
[email protected]
Date
2012-03-23 22:21:26 -0700 (Fri, 23 Mar 2012)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
<rdar://problem/11094830> WebProcess appears to get stuck in its GC handler (81963).
Remove the call to garbage collect  in low memory signal handler.  Did some testing with hitting the low memory handler
during Membuster and we would get back at most 100k - 200k.  That isn't enough to help the system, and in
that state the GC collection can take a substantial amount of time.

Reviewed by Geoff Garen.

Performance Change, no change in behavior.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111976 => 111977)


--- trunk/Source/WebCore/ChangeLog	2012-03-24 04:04:27 UTC (rev 111976)
+++ trunk/Source/WebCore/ChangeLog	2012-03-24 05:21:26 UTC (rev 111977)
@@ -1,3 +1,18 @@
+2012-03-23  Stephanie Lewis  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
+        <rdar://problem/11094830> WebProcess appears to get stuck in its GC handler (81963).
+        Remove the call to garbage collect  in low memory signal handler.  Did some testing with hitting the low memory handler
+        during Membuster and we would get back at most 100k - 200k.  That isn't enough to help the system, and in 
+        that state the GC collection can take a substantial amount of time.
+
+        Reviewed by Geoff Garen.
+
+        Performance Change, no change in behavior.
+
+        * platform/mac/MemoryPressureHandlerMac.mm:
+        (WebCore::MemoryPressureHandler::releaseMemory):
+
 2012-03-23  W. James MacLean  <[email protected]>
 
         [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.

Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (111976 => 111977)


--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-03-24 04:04:27 UTC (rev 111976)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-03-24 05:21:26 UTC (rev 111977)
@@ -135,8 +135,6 @@
 
     memoryCache()->pruneToPercentage(critical ? 0 : 0.5f);
 
-    gcController().garbageCollectNow();
-
     WTF::releaseFastMallocFreeMemory();
 }
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to