Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce1f3beb0d2dca31c64989cd776bab67bbbac554
https://github.com/WebKit/WebKit/commit/ce1f3beb0d2dca31c64989cd776bab67bbbac554
Author: Alex Christensen <[email protected]>
Date: 2025-01-13 (Mon, 13 Jan 2025)
Changed paths:
M Source/WebCore/loader/ResourceLoader.cpp
Log Message:
-----------
Null check FrameLoader from ResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=285880
rdar://142839482
Reviewed by Pascoe.
288750@main made it so m_frame can become null at different times.
I added null checks for m_frame, but not for calls to frameLoader().
I have logs that indicate this caused crashes in a few places.
This adds null checks everywhere except where we are getting a
ResourceError from the FrameLoaderClient, which I will soon replace
with a call to LoaderStrategy.
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveBuffer):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceLoader::connectionProperties):
Canonical link: https://commits.webkit.org/288822@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
