Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8e0fc5af568b513af2ee869301ba2be6237cc8df
https://github.com/WebKit/WebKit/commit/8e0fc5af568b513af2ee869301ba2be6237cc8df
Author: Timothy Hatcher <[email protected]>
Date: 2025-01-15 (Wed, 15 Jan 2025)
Changed paths:
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm
Log Message:
-----------
REGRESSION: "tabs" field missing from windows.create returned windows.Window.
https://webkit.org/b/282025
rdar://problem/138529797
Reviewed by Brian Weinstein.
Make sure to pass PopulateTabs::Yes when returning the new window parameters.
Added tests and test harness support for creating windows with URLs.
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeOpenOptionsPage): Drive-by error string
fix.
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsCreate): Drive-by error string fix.
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm:
(WebKit::WebExtensionContext::windowsCreate): Pass PopulateTabs::Yes
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::duplicate): Drive-by error string fix.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, Create)): Test window.tabs
result.
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURL)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURLs)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows,
CreateIncognitoWithPrivateAccess)): Ditto.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager
initForExtension:extensionControllerConfiguration:]): Support tabURLs.
Canonical link: https://commits.webkit.org/288949@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
