Title: [112020] trunk/Source/WebCore
- Revision
- 112020
- Author
- [email protected]
- Date
- 2012-03-24 20:59:40 -0700 (Sat, 24 Mar 2012)
Log Message
Quick fix for rendering controls regression.
https://bugs.webkit.org/show_bug.cgi?id=82125
Patch by Victor Carbune <[email protected]> on 2012-03-24
Reviewed by Eric Carlson.
Only temporary fix. Tests to cover the problem should be added
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeOpaque): The display:none
property should be toggled only by the media element now.
(WebCore::MediaControlPanelElement::makeTransparent): The timer
that toggles the dispalay:none shouldn't be used now.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112019 => 112020)
--- trunk/Source/WebCore/ChangeLog 2012-03-25 03:50:49 UTC (rev 112019)
+++ trunk/Source/WebCore/ChangeLog 2012-03-25 03:59:40 UTC (rev 112020)
@@ -1,3 +1,18 @@
+2012-03-24 Victor Carbune <[email protected]>
+
+ Quick fix for rendering controls regression.
+ https://bugs.webkit.org/show_bug.cgi?id=82125
+
+ Reviewed by Eric Carlson.
+
+ Only temporary fix. Tests to cover the problem should be added
+
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlPanelElement::makeOpaque): The display:none
+ property should be toggled only by the media element now.
+ (WebCore::MediaControlPanelElement::makeTransparent): The timer
+ that toggles the dispalay:none shouldn't be used now.
+
2012-03-24 Kevin Ollivier <[email protected]>
[wx] Unreviewed. Add header needed for compilation.
Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (112019 => 112020)
--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-03-25 03:50:49 UTC (rev 112019)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-03-25 03:59:40 UTC (rev 112020)
@@ -242,7 +242,9 @@
m_opaque = true;
- show();
+ // FIXME(BUG 79347): The display:none property should be toggled below only
+ // when display logic is introduced.
+ // show();
}
void MediaControlPanelElement::makeTransparent()
@@ -256,7 +258,9 @@
m_opaque = false;
- startTimer();
+ // FIXME(BUG 79347): The display:none property should be toggled below
+ // (through the timer start) when display logic is introduced.
+ // startTimer();
}
void MediaControlPanelElement::defaultEventHandler(Event* event)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
