Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 90e2c985216e10295f71c0d738e1ff316272d754
https://github.com/WebKit/WebKit/commit/90e2c985216e10295f71c0d738e1ff316272d754
Author: Ahmad Saleem <[email protected]>
Date: 2025-01-17 (Fri, 17 Jan 2025)
Changed paths:
A LayoutTests/fast/table/section-with-opaque-background-expected.html
A LayoutTests/fast/table/section-with-opaque-background.html
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableRow.h
M Source/WebCore/rendering/RenderTableSection.h
Log Message:
-----------
Don't treat table section and row background as opaque
https://bugs.webkit.org/show_bug.cgi?id=285288
rdar://142588505
Reviewed by Antti Koivisto.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/678668f1438249f61c0f3a422dba6e8e1ad2a811
Previously we tested background opaqueness of table sections and rows
using the normal RenderBox method, which treats the background as opaque
if there is opaque background style. This was incorrect for table
sections and rows because their background just covers cells, not the
whole object. The area of table border spacing, missing cells,
etc. are actually transparent.
For simplicity, just treat background of all table sections and rows
not opaque.
Also override foreground opaqueness testing of table, section and row to
shortcut opaqueness testing in
RenderBox::computeBackgroundIsKnownToBeObscured().
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableRow.h:
* Source/WebCore/rendering/RenderTableSection.h:
* LayoutTests/fast/table/section-with-opaque-background.html: Add Test Case
* LayoutTests/fast/table/section-with-opaque-background-expected.html: Add Test
Case Expectation
Canonical link: https://commits.webkit.org/289047@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
