Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bd9273e8765dcb7910218c2e2e080bd1f3afc544
https://github.com/WebKit/WebKit/commit/bd9273e8765dcb7910218c2e2e080bd1f3afc544
Author: Tyler Wilcock <[email protected]>
Date: 2025-01-23 (Thu, 23 Jan 2025)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: Include list markers in the output of AXStringForTextMarkerRange with
ENABLE(AX_THREAD_TEXT_APIS)
https://bugs.webkit.org/show_bug.cgi?id=286378
rdar://143420875
Reviewed by Chris Fleizach.
With this commit, in ENABLE(AX_THREAD_TEXT_APIS) mode we now include list
marker text when turning an AXTextMarkerRange
into a string (but only for the line of text actually associated with the list
marker).
This fixes accessibility/mac/listmarker-suffix.html and mostly fixes
accessibility/mac/attributed-string-with-listitem-multiple-lines.html,
which still fails only because we don't seem to handle white-space-collapse:
preserve correctly, which is an unrelated problem.
This patch includes a drive-by fix to AXIsolatedTree::setProperty, which did
not handle TagName in its WTF::switchOn.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::rangeWithSameStyle const):
(WebCore::AXTextMarkerRange::toString const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::lineStartListMarkerText):
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::listMarkerText): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textRuns):
(WebCore::AccessibilityRenderObject::markerRenderer const):
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::setProperty):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/289289@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
